Support GATs and containers in more places #550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract MapInPlace from Map; make Map GAT-aware This allows us to implement `map` for `TimelyStack`. Note that this is a breaking change because the `map_in_place` methods moves from the `Map` trait to the new `MapInPlace` trait. This is required because it needs mutable access to data, which `TimelyStack` (and others) cannot provide.
This was referenced Mar 22, 2024
|
Handled elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract MapInPlace from Map; make Map GAT-aware
This allows us to implement
mapforTimelyStack.Note that this is a breaking change because the
map_in_placemethodsmoves from the
Maptrait to the newMapInPlacetrait. This is requiredbecause it needs mutable access to data, which
TimelyStack(and others)cannot provide.