PartialOrder with Rhs type parameter #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the `PartialOrder` trait to have an optional right-hand side type. This allows us to implement partial order for unequal types, which comes in handy when working with complex timestamp times that a container might store as a GAT instead of the actual type. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
partial_order_rhs
branch
from
179d6f7 to
b73e476
Compare
frankmcsherry
approved these changes
May 22, 2024
timely/src/progress/frontier.rs
Outdated
| /// assert!(frontier.insert_or_else(&2, |x| *x)); | ||
| /// assert!(!frontier.insert(3)); | ||
| ///``` | ||
| pub fn insert_or_else<O: PartialOrder<T>, F: FnOnce(&O) -> T>(&mut self, element: &O, to_owned: F) -> bool where T: Clone + PartialOrder<O> { |
There was a problem hiding this comment.
Nit, but I think _or_else isn't right, in that on insertion it does use the to_owned function. What about insert_with or something similar?
There was a problem hiding this comment.
Changed to insert_with.
timely/src/progress/frontier.rs
Outdated
Comment on lines
481
to
482
| O: PartialOrder<T>, | ||
| T: PartialOrder<O>, |
There was a problem hiding this comment.
One of these two is surprising, but I don't know which. Probably O: PartialOrder<T>. With a time: &O, surely we can compare the elements of self.frontier() to time just using T: PartialOrder<O>?
| where | ||
| T: PartialOrder, | ||
| O: PartialOrder<T>, | ||
| T: PartialOrder<O>, |
There was a problem hiding this comment.
Similar as above; is one constraint unnecessary?
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
partial_order_rhs
branch
from
1df2749 to
4962a76
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
Rhsparameter toPartialOrder, to allow comparison between different types. This helps to compare types stored in containers in a different form than their original structure.