Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the IterContainer type and reworks other types and
implementations to function independently. Notably, this is a breaking
change for users of exotic containers:
Inspect
trait defers to&C: IntoIterator
to reveal items incontainers. Not all currently used containers provide this. Vec does,
but Rc/Arc and Column don't and do not plan to in the future. Users
should pivot to
inspect_container
instead and internalize the iterationin the closure.
DrainContainer
implementaiton for Rc/Arc depends on the wrappedtype implementing
IntoIterator
for references. This limits wherewrapped containers that do not provide this can be used. It's mostly
limited to the core Timely layer that doesn't provide element-by-element
functionality.
I feel this change is net positive as it defers to the Rust API to iterate
existing types, instead of us providing our own infrastructure. It comes
at a cost of potentially breaking existing code, which seems acceptable.