Skip to content

Support PHP 8.1 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Support PHP 8.1 #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66ecca2
#1 Update Location class to reflect ArrayAccess interface changes
alies-dev Dec 10, 2021
f0b7b0b
#1 Change min supported PHP version to 8.0
alies-dev Dec 10, 2021
65f2fea
#4 Remove redundant version declaration
alies-dev Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}
],
"require": {
"php": "^7.3|^8.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^8.1 is not needed as ^8.0 is equivalent to >=8.0 <9.0. So just dropping ^7.3 is good enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

"php": "^8.0",
"illuminate/support": "^8.0",
"illuminate/console": "^8.0",
"illuminate/cache": "^8.0"
Expand Down
8 changes: 4 additions & 4 deletions src/Location.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public function __set($key, $value)
*
* @return bool
*/
public function offsetExists($offset)
public function offsetExists(mixed $offset): bool
{
return isset($this->$offset);
}
Expand All @@ -166,7 +166,7 @@ public function offsetExists($offset)
*
* @return mixed
*/
public function offsetGet($offset)
public function offsetGet(mixed $offset): mixed
{
return $this->$offset;
}
Expand All @@ -179,7 +179,7 @@ public function offsetGet($offset)
*
* @return void
*/
public function offsetSet($offset, $value)
public function offsetSet(mixed $offset, mixed $value): void
{
$this->$offset = $value;
}
Expand All @@ -191,7 +191,7 @@ public function offsetSet($offset, $value)
*
* @return void
*/
public function offsetUnset($offset)
public function offsetUnset(mixed $offset): void
{
unset($this->$offset);
}
Expand Down