-
Notifications
You must be signed in to change notification settings - Fork 230
Restrict tests to FillArrays 1.0.0 #2014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Shouldn't we also (even retro-actively) bound FillArrays in the Turing package itself to avoid that users run into these issues? |
|
Possibly! My worry about that is that:
IMO we don't for now, and then if we get people running into this issue in practice, we bound Turing too. |
|
In my impression this FillArrays issue is a major problem as it affects (log) normal distributions (see, e.g., https://github.com/TuringLang/DistributionsAD.jl/actions/runs/5258560449/jobs/9502944457). I guess there are just not more test failures in Turing since we don't test as exhaustively as in DistributionsAD. Hence I think we should completely remove any use of FillArrays > 1.0.0 from the Turing ecosystem until these upstream issues are debugged and fixed. |
Pull Request Test Coverage Report for Build 5304666098
💛 - Coveralls |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2014 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 21 21
Lines 1427 1427
======================================
Misses 1427 1427 ☔ View full report in Codecov by Sentry. |
|
Aight, let's do that then 👍 |
| # NOTE: Used to use `InverseGamma(2, 3)` but this has infinite variance | ||
| # which means that it's _very_ difficult to find a good tolerance in the test below:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No wonder this test has been causing so much annoyance 😅
|
Happy with this now @devmotion ?:) |
Attempt to fix tests as per TuringLang/DistributionsAD.jl#248