Skip to content

fix: Error thrown on Backspace in first block #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: Error thrown on Backspace in first block #1165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 30 additions & 29 deletions packages/core/src/extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,40 +114,41 @@ export const KeyboardShortcutsExtension = Extension.create<{
const selectionEmpty = state.selection.empty;
const blockAtDocStart = blockInfo.blockContainer.beforePos === 1;

const prevBlockPos = getPrevBlockPos(
state.doc,
state.doc.resolve(blockInfo.blockContainer.beforePos)
);
const prevBlockInfo = getBlockInfoFromResolvedPos(
state.doc.resolve(prevBlockPos.pos)
);

const prevBlockNotTableAndNoContent =
prevBlockInfo.blockContent.node.type.spec.content === "" ||
(prevBlockInfo.blockContent.node.type.spec.content ===
"inline*" &&
prevBlockInfo.blockContent.node.childCount === 0);

if (
!blockAtDocStart &&
selectionAtBlockStart &&
selectionEmpty &&
depth === 1 &&
prevBlockNotTableAndNoContent
depth === 1
) {
return chain()
.cut(
{
from: blockInfo.blockContainer.beforePos,
to: blockInfo.blockContainer.afterPos,
},
prevBlockInfo.blockContainer.afterPos
)
.deleteRange({
from: prevBlockInfo.blockContainer.beforePos,
to: prevBlockInfo.blockContainer.afterPos,
})
.run();
const prevBlockPos = getPrevBlockPos(
state.doc,
state.doc.resolve(blockInfo.blockContainer.beforePos)
);
const prevBlockInfo = getBlockInfoFromResolvedPos(
state.doc.resolve(prevBlockPos.pos)
);

const prevBlockNotTableAndNoContent =
prevBlockInfo.blockContent.node.type.spec.content === "" ||
(prevBlockInfo.blockContent.node.type.spec.content ===
"inline*" &&
prevBlockInfo.blockContent.node.childCount === 0);

if (prevBlockNotTableAndNoContent) {
return chain()
.cut(
{
from: blockInfo.blockContainer.beforePos,
to: blockInfo.blockContainer.afterPos,
},
prevBlockInfo.blockContainer.afterPos
)
.deleteRange({
from: prevBlockInfo.blockContainer.beforePos,
to: prevBlockInfo.blockContainer.afterPos,
})
.run();
}
}

return false;
Expand Down
Loading