Skip to content

Conversation

mwonng
Copy link
Contributor

@mwonng mwonng commented Oct 24, 2024

PR Summary

Fix caption width issue it now able to sync when reizing.

The way fix it just to set same width, but this might not perfect solution.

Note: potential problem:

  • when caption trim by white space, it will go another line, but we cant decide when it change line.
  • due to same pixel, it might not good when we have some element on left or right overlapped.(this can be fix if have proper padding for caption paragraph tag)
  • I notice when it resize it will actualy re-render the whole block container, this can be improve.

Video:

caption-auto-resize.mp4

Screenshots:

Snipaste_2024-10-25_00-05-28
Snipaste_2024-10-25_00-05-40

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Oct 24, 2024 1:23pm

Copy link

vercel bot commented Oct 24, 2024

@mwonng is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@YousefED YousefED merged commit 00483ea into TypeCellOS:main Oct 30, 2024
1 of 3 checks passed
@YousefED YousefED mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants