Skip to content

fix: Clipboard insertion with multiple data types #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix: Clipboard insertion with multiple data types #1224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52eb08d
Made reading files lower priority than reading text when inserting fr…
matthewlipski Nov 7, 2024
8ca8733
Added warning when `uploadFile` is not defined when inserting file
matthewlipski Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/api/clipboard/fromClipboard/acceptedMIMETypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export const acceptedMIMETypes = [
"vscode-editor-data",
"blocknote/html",
"Files",
"text/html",
"text/plain",
"Files",
] as const;
4 changes: 4 additions & 0 deletions packages/core/src/api/clipboard/fromClipboard/handleFileInsertion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ export async function handleFileInsertion<
S extends StyleSchema
>(event: DragEvent | ClipboardEvent, editor: BlockNoteEditor<BSchema, I, S>) {
if (!editor.uploadFile) {
// eslint-disable-next-line no-console
console.warn(
"Attempted ot insert file, but uploadFile is not set in the BlockNote editor options"
);
return;
}

Expand Down
Loading