fix: Overlapping marks in comments #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Yea, in my testing this is working sort of how I'd expect it. Old comments are still preserved & work properly. Older clients seeing new comments are problematic. The good thing is that we just released commenting in general. So this won't really be of much concern for us. Unfortunately, I don't see a better way around this, while still preserving the ability to comment on the same text concurrently. So, an acceptable tradeoff to make. |
nperez0111
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates y-prosemirror to v1.3.0, which adds support for overlapping marks. While updating the package does fix the issue, it seems to be pretty much incompatible with clients running the older version. Clients running the new version can still view, resolve, react to, reply to, and delete existing comments, but trying to create a new thread doesn't work properly.
The mark is created correctly and the thread + comment are added to the thread store, but the block containing the mark are deleted immediately after. I spent some time looking into this but could not figure out where this deletion is happening.
Documents which only have clients on the new version work fine.