Skip to content

Pass blockId to uploadFile in UploadTab #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Pass blockId to uploadFile in UploadTab #1641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d74f923
refactor(core): rename block to blockId
Apr 24, 2025
0bf7ee4
feat(file-panel): add blockId parameter to the call of editor.uploadFile
Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/core/src/editor/BlockNoteEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,15 +625,15 @@ export class BlockNoteEditor<

if (newOptions.uploadFile) {
const uploadFile = newOptions.uploadFile;
this.uploadFile = async (file, block) => {
this.uploadFile = async (file, blockId) => {
this.onUploadStartCallbacks.forEach((callback) =>
callback.apply(this, [block])
callback.apply(this, [blockId])
);
try {
return await uploadFile(file, block);
return await uploadFile(file, blockId);
} finally {
this.onUploadEndCallbacks.forEach((callback) =>
callback.apply(this, [block])
callback.apply(this, [blockId])
);
}
};
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/FilePanel/DefaultTabs/UploadTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const UploadTab = <

if (editor.uploadFile !== undefined) {
try {
let updateData = await editor.uploadFile(file);
let updateData = await editor.uploadFile(file, block.id);
if (typeof updateData === "string") {
// received a url
updateData = {
Expand Down
Loading