fix: menu positioning when scrolling #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Best we can do for now.
A more ideal solution would be if we the menus would be locate relatively in the editor. In that case CSS should be able to take care of the positioning, and we don't have to manually update it.
However, this would be a bit cumbersome to fix now I think as menus are located at a different position in the HTML tree. We should create a separate issue for this
fogle
pushed a commit
to fogle/BlockNote
that referenced
this pull request
May 20, 2023
* Made all menus/toolbars scroll with page * Revert "Made all menus/toolbars scroll with page" This reverts commit 6071095. * Made all menus/toolbars scroll with page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menus and toolbars currently stay in place when the page is scrolled. This PR makes makes their positions update on scroll.
closes #165