fix: Isolated drag/drop per editor instance #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fogle
pushed a commit
to fogle/BlockNote
that referenced
this pull request
May 20, 2023
* Made dragging & dropping confined to the editor instance * Reverted drop cursor fix * Minor change * Fixed build error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, drag/drop was broken with multiple side-by-side editor instances, as dropping blocks outside the editor in the x dimension was coded to instead drop them at the editor's center x coord. This meant that whichever editor's
droplistener fired first would receive the block. Now, each editor instance only listens for drag/drop events if the content in them came from that same editor instance. The drop cursor has also been modified to work in this way.Closes #173