Skip to content

fix: bn-inline-content class name getting duplicated #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

fix: bn-inline-content class name getting duplicated #1794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee5c361
Fixed `bn-inline-content` class name being added to React custom bloc…
matthewlipski Jun 26, 2025
8d15c2a
Improved `mergeCSSClasses`
matthewlipski Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/core/src/util/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,17 @@ export function formatKeyboardShortcut(shortcut: string, ctrlText = "Ctrl") {
}

export function mergeCSSClasses(...classes: (string | false | undefined)[]) {
return classes.filter((c) => c).join(" ");
return [
// Converts to & from set to remove duplicates.
...new Set(
classes
.filter((c) => c)
// Ensures that if multiple classes are passed as a single string, they
// are split.
.join(" ")
.split(" "),
),
].join(" ");
}

export const isSafari = () =>
Expand Down
Loading