Skip to content

fix: resolve some minor drag & drop regressions #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

fix: resolve some minor drag & drop regressions #1862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc3262f
fix: allow dragging between blocks again
nperez0111 Jul 21, 2025
9ef143e
fix: always try to collapse the selection, unless text is being dragged
nperez0111 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/core/src/extensions/SideMenu/SideMenuPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,21 +498,19 @@ export class SideMenuView<
}
const { isDropPoint, isDropWithinEditorBounds, isDragOrigin } = context;

if (!isDropWithinEditorBounds) {
if (!isDropWithinEditorBounds && isDropPoint) {
// Any time that the drop event is outside of the editor bounds (but still close to an editor instance)
// We dispatch a synthetic event that is in the bounds of the editor instance, to have the correct drop point
this.dispatchSyntheticEvent(event);
}

if (isDropPoint && isDragOrigin) {
// The current instance is both the drop point and the drag origin
// no-op, normal drop handling will take over
return;
}

if (isDropPoint) {
// The current instance is the drop point, but not the drag origin
// The current instance is the drop point

if (this.pmView.dragging) {
// Do not collapse selection when text content is being dragged
return;
}
// Because the editor selection is unrelated to the dragged content, we
// don't want PM to delete its content. Therefore, we collapse the
// selection.
Expand Down
Loading