fix: Vanilla blocks return true
for editor.isEditable
on initial render
#1925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where getting
editor.isEditable
in therender
function of a vanilla JS block would returntrue
, regardless of if the editor is actually editable.This is because
editor.isEditable
is set in auseEffect
hook inBlockNoteViewComponent
, which updates the value async, and so it can happen after the block has already rendered.I've changed it so
editor.isEditable
is also set inBlockNoteViewEditor
, before the editor is mounted, ensuring the value is correct before any vanilla blocks are rendered.Closes #1477