Skip to content

Conversation

matthewlipski
Copy link
Collaborator

@matthewlipski matthewlipski commented Oct 6, 2025

Summary

This PR fixes a variety of issues with the toggle list item block, as well as fixing styling for check list item blocks.

Closes #2067

Rationale

These two blocks are currently not working as intended. The check list item block is mostly ok and just needs styles tweaked. The toggle list item block has a bunch of issues though, regarding rendering, exporting, etc.

Changes

  • Adjusted check list item render and styles.
  • Fixed toggle list item blocks not showing the toggle button.
  • Fixed toggle list items not being exported to external HTML in the proper list structure.
  • Fixed serializeBlock passing undefined children in Block to render.

Impact

The check list and toggle list item blocks are part of the default blocks, so this fix is fairly critical.

Testing

  • Added toggle list item blocks to unit tests which include all default blocks.
  • Added e2e test to screenshot all basic blocks, to prevent styling regressions.

Screenshots/Video

Checklist

  • Code follows the project's coding standards.
  • Unit tests covering the new feature have been added.
  • All existing tests pass.
  • The documentation has been updated to reflect the new feature

Additional Notes

Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
blocknote Ready Ready Preview Oct 7, 2025 5:37pm
blocknote-website Ready Ready Preview Oct 7, 2025 5:37pm

Copy link

pkg-pr-new bot commented Oct 6, 2025

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@2071

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@2071

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@2071

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@2071

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@2071

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@2071

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@2071

@blocknote/xl-ai

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-ai@2071

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@2071

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-email-exporter@2071

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@2071

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@2071

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@2071

commit: c8b5812

@nperez0111 nperez0111 merged commit 86c3378 into main Oct 8, 2025
11 of 12 checks passed
@nperez0111 nperez0111 deleted the list-items-fixes branch October 8, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle lists broken v0.39.1 onwards
3 participants