simplify ui elements #288
Merged
simplify ui elements #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
commented
Jul 31, 2023
| updateSuggestionsMenu(this.suggestionsMenuState); | ||
| }; | ||
|
|
||
| this.itemCallback = (item: T) => { |
Collaborator
Author
There was a problem hiding this comment.
I don't think this was used
Collaborator
matthewlipski
left a comment
matthewlipski
left a comment
There was a problem hiding this comment.
Nice! Much less code than before. As far as I can see it's mostly due to grouping the UI plugins in a single extension and and moving logic from BlockNoteEditor to EventEmitter. I am wondering though about using EventEmitter vs just adding similar logic to BlockNoteEditor, and I have a few questions about that.
packages/react/src/SlashMenu/components/SlashMenuPositioner.tsx
Outdated
Show resolved
Hide resolved
…BlockNote into react-rearchitecture-callbacks
matthewlipski
added a commit
that referenced
this pull request
Aug 1, 2023
* test react components as children * slashmenu * Major refactor * Exported plugin keys & cleaned up slash menu plugin * Removed redundant type * Commented out old factory & component wrapper * Removed old files & fixed build * Small cleanup * Fixed some bugs in the slash and side menus * Made menu & toolbar plugins load with the highest priority instead of the lowest * Disabled strict mode * Fixed a bug which caused plugin views to be created multiple times * several fixes for react rearchitecture (#272) * Major cleanup for menus & toolbars * Major cleanup for menus & toolbars * Cleaned up `useBlockNote`, menu & toolbar components * Changed menu & toolbar APIs to work with the new rendering architecture * Numerous changes: - Menu extensions are now initialized on editor creation and expose listeners - Cleaned up slash menu item creation and typing - Fixed drag & drop causing errors when calling `getBlockInfoFromPos` * Fixed menus being initialized early * Fixed some deps * Reverted some deps * Added lint ignore annotations to deps * Cleaned up slash menu and suggestion items * Cleaned up `BlockNoteEditor` * Revert "Cleaned up `BlockNoteEditor`" This reverts commit 5409f8b. * Minor changes * Minor changes & update to formatting toolbar docs * simplify ui elements (#288) * simplify ui elements * remove unused * fix view * Fixed build * add onUpdate * fix vanilla * fix build * allow props for blocknoteview --------- Co-authored-by: Matthew Lipski <[email protected]> * Implemented PR feedback * Implemented PR feedback * Implemented PR feedback * Implemented PR feedback * Added docs & small tweaks * Renamed remaining slashCommand references to slashMenuItems * Implemented PR feedback * Fixed lint warning * fix initialcontent and uniqueid (#289) * fix initialcontent and uniqueid * fix * Removed ready check in `BlockNoteView` --------- Co-authored-by: Matthew Lipski <[email protected]> * Added pre-made components for side menu * Added custom side menu docs * Updated docs * Updated unit tests & snapshots * Updated `useBlockNote` deps --------- Co-authored-by: yousefed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for a simplified setup of the ui elements