small fixes #346
Merged
small fixes #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
commented
Sep 22, 2023
YousefED
commented
Sep 22, 2023
matthewlipski
approved these changes
Sep 22, 2023
# Conflicts: # packages/react/src/ImageToolbar/components/DefaultImageToolbar.tsx
matthewlipski
added a commit
that referenced
this pull request
Oct 3, 2023
* Made formatting toolbar buttons not show if they are not applicable * Made formatting toolbar placement change based on text alignment * Improved typing for blocks without inline content and made them selectable * Updated default blocks with new typing * Added image block (React implementation) * Added image upload and caption formatting toolbar buttons * Added image slash menu item * Temporarily updated `App.tsx` to show image block * Added placeholder `alt` attribute to image * Added `destroy` function so vanilla custom blocks can clean ip between renders * Added vanilla image block * Added Uppy deps * Updated `ReplaceImageButton.tsx` * Small fix in `BlockColorsButton.tsx` * Typing fix for hyperlink toolbar components * Created reusable components for link & caption components * Fixed import issue * Made image selection border also include caption * Added comment * Added new hooks to clean up code * Updated exports * Changed image replacing from Uppy to custom UI and removed `replacing` prop * Fixed z-index for UI elements * Changed image `width` prop to be in px * Removed Uppy dependency * Reverted `App.tsx` * Removed React image block implementation * Fixed exports * Fixed image block imports * Small fixes to tests * Changed image replacement to use image specific toolbar * Made image toolbar open immediately after inserting an image using the slash menu * Fixed replace image button having persistent `open` state * `ImageToolbarPositioner.tsx` cleanup * Made image toolbar design more similar to Notion * Cleaned up block typing * Implemented PR feedback * Removed redundant z-index style from `ColorStyleButton` * Made props able to be any primitive type and cleaned up test snapshots * Extracted image styles to CSS * Refactored `DefaultImageToolbar` * Added editor option for consumers to handle image uploads * Small `FormattingToolbarPositioner` refactor * Fixed image slash menu item bug * Changed image toolbar to use tabs and fixed dark theme * Renamed image `src` prop to `url` * Changed how image width is constrained to editor width * Updated default color names * Added loading overlay to the image toolbar while an image is being uploaded * Fixed heading in block tyupe dropdown * small fixes (#346) * small fixes * Updated `uploadFile` JSDoc * Extracted example file upload function to new file removed it as a default --------- Co-authored-by: Matthew Lipski <[email protected]> * Small hook fix * Added image docs * Updated unit test snapshots * Added image e2e tests * Added error handling for image uploads * Renamed example image upload handler * Added example image upload handler to docs home page * Small fixes * Added test snapshots/screenshots * Improved e2e test reliability --------- Co-authored-by: Yousef <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.