fix(side-menu): fix edge case when hovering group instead of a block #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This typically can happen when you add `display: flex` to `.bn-block-group` with a gap. You can then happen to hover the group itself instead of a block or outer block element When this happens, the id that would be given to `editor.getBlock` would be `null`, making it fail.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@clementprevot is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
YousefED
reviewed
Jun 5, 2024
|
|
||
| this.hoveredBlock = block.node; | ||
|
|
||
| if (!this.hoveredBlock?.hasAttribute("data-id")) { |
There was a problem hiding this comment.
@matthewlipski can you review this, and also see if this check should be here or not? Could it also be that hoveredBlock shouldn't have been set in the first place if it doesn't have data-id?
|
Thanks for your submission! Your solution does indeed fix this issue, though after looking through the code I figured there was some more fundamental issues with it that should also be fixed along with this bug. I created a new PR with those changes, see #814 for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This typically can happen when you add
display: flexto.bn-block-groupwith a gap.You can then happen to hover the group itself instead of a block or outer block element
When this happens, the id that would be given to
editor.getBlockwould benull, making it fail (by the way, adding an optional chaining operator or checking for null/undefined here may be a good idea, let me know if you want me to make a PR for that).