Skip to content

Conversation

@hitochan777
Copy link

@hitochan777 hitochan777 commented Jan 24, 2018

This PR fixes the bug of the environment variables TS_NODE_TYPE_CHECK and TS_NODE_CACHE not taking effect.
This is because cache and typeCheck are set to null by default, so options.cache === undefined and options.typeCheck === undefined are never evaluated to true.
I thought of setting the default values to undefined, but minimist sets undefined options to the default values of their types, which is false.
So, I ended up negating option.cache and options.typeCheck, though I don't know this is the best choice.

@coveralls
Copy link

coveralls commented Jan 24, 2018

Coverage Status

Coverage remained the same at 77.427% when pulling 3e9d732 on hitochan777:fix-env-var-not-in-effect into d5a941c on TypeStrong:master.

@blakeembrey
Copy link
Member

Should be fixed with #536.

@hitochan777 hitochan777 deleted the fix-env-var-not-in-effect branch February 20, 2018 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants