Skip to content

Conversation

@DanGiles
Copy link

@DanGiles DanGiles commented Nov 6, 2023

No description provided.

Copy link

@themkots themkots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It is first used inside an if, so ... OK.

Copy link

@themkots themkots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I have removed lines 57 and 58 and no errors came up. This # ifdef was outside an # ifdef HAVE_MPI before, so the CPPFLAGS in the Makefile was missing SCOTCH_INCS and I had errors / breaks in the build. After moving it inside HAVE_MPI fence, it was OK, but they turn out to be redundant.

@themkots themkots merged commit 5d78376 into master Nov 6, 2023
@DanGiles DanGiles deleted the DanGiles-patch-1 branch November 6, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants