feat(Notification): initial Implementation #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 73.96% 74.17% +0.21%
==========================================
Files 156 158 +2
Lines 3618 3721 +103
Branches 639 669 +30
==========================================
+ Hits 2676 2760 +84
- Misses 720 734 +14
- Partials 222 227 +5
Continue to review full report at Codecov.
|
Contributor
|
I will leave this PR open for the moment, we want to make sure that all bugs are gone in v0.6.0 before we add new components. |
MarcusNotheis
requested changes
Oct 30, 2019
# Conflicts: # packages/main/src/index.ts
|
Deploy preview for ui5-webcomponents-react ready! Built with commit f283f53 https://deploy-preview-171--ui5-webcomponents-react.netlify.com |
MarcusNotheis
requested changes
Nov 6, 2019
MarcusNotheis
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159
Closes #160