fix(bug): remove chain id from transaction options #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shutt <[email protected]>
pemulis
requested review from
a team,
daywiss and
smb2796
and removed request for
a team
smb2796
approved these changes
Jul 27, 2021
daywiss
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Shutt [email protected]
This bug was reported on Discord, with discussion above @smb2796's comment: https://discord.com/channels/718590743446290492/718591751543062548/868199865421791252
Commenting out the offending line solved the bug for sumitpatel93. The chain ID line is not included in
launch-lsp, either, and appears to be outdated with new versions of@uma/core.