This repository was archived by the owner on Jan 31, 2025. It is now read-only.
Impl serializer interface and json serializer #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It was almost done, isn't it ? Just give me some unittests. However, you could read this material, How to write a good commit message(Chinese). I'm not saying you did a bad job. Just have something you can improve. |
Open
Contributor
|
@as23041248 , please rebase your branch. We import many features like CI and Makefile, which can test your code automatically. |
amikai
force-pushed
the
feature/serialization
branch
from
e29ae6e to
9a682b6
Compare
iankuan
approved these changes
Oct 6, 2017
Contributor
iankuan
left a comment
iankuan
left a comment
There was a problem hiding this comment.
Seems great. By the way, I notice that this branch feature/serialization doesn't catch up mainline. Please rebasing it after few minutes.
amikai
force-pushed
the
feature/serialization
branch
2 times, most recently
from
fd0b9d1 to
4d1f642
Compare
iankuan
reviewed
Oct 7, 2017
amikai
force-pushed
the
feature/serialization
branch
2 times, most recently
from
7a18341 to
3c2c250
Compare
The serializer in Json convert python dict to string(raw data), and deserializer convert string(raw data) to python dict.
amikai
force-pushed
the
feature/serialization
branch
from
3c2c250 to
884ea53
Compare
iankuan
suggested changes
Oct 7, 2017
Contributor
iankuan
left a comment
iankuan
left a comment
There was a problem hiding this comment.
Meld last two commits into one. Hint: "rebase -i" and then "-f fixup".
Test json serializer by converting between python dict and raw json data.
amikai
force-pushed
the
feature/serialization
branch
from
884ea53 to
22acb5c
Compare
amikai
changed the title
iankuan
approved these changes
Oct 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is add a feature which describes in #12.
The three thing i do in this PR: