Fix ecosystem file reload not updating non-environment attributes #6029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Unitech#3742 When using 'pm2 restart ecosystem.config.js' or 'pm2 reload ecosystem.config.js', only environment variables were being updated from the ecosystem file. Other configuration attributes like script path, cwd, interpreter, etc. were ignored. This fix modifies the _startJson method in lib/API.js to pass the complete application configuration (not just environment variables) when performing restart/reload operations on ecosystem files. Changes: - Extract complete app configuration from ecosystem file during restart/reload - Pass configuration as current_conf to enable extendExtraConfig processing - Remove env property from config copy to avoid duplication - Maintains backward compatibility with existing environment variable handling Now all ecosystem file attributes (script, cwd, interpreter, instances, etc.) are properly updated during restart/reload operations, eliminating the need for 'pm2 kill && pm2 start' workarounds that cause unnecessary downtime.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3742 -
pm2 restart ecosystem.config.jsdoes not reload app details from ecosystem fileWhen using
pm2 restart ecosystem.config.jsorpm2 reload ecosystem.config.js, only environment variables were being updated from the ecosystem file. Other configuration attributes like script path, cwd, interpreter, etc. were ignored.Root Cause
The
_startJsonmethod inlib/API.jswas only passing environment variables to the_operatemethod during restart/reload operations, but not the complete application configuration needed to update non-environment attributes.Solution
Modified the
_startJsonmethod to pass the complete application configuration ascurrent_confwhen performing restart/reload operations on ecosystem files. This enables the existingUtility.extendExtraConfigmechanism to update all configuration attributes.Changes
current_confto enableextendExtraConfigprocessingenvproperty from config copy to avoid duplication with existing env handlingTesting
Impact
pm2 kill && pm2 startworkarounds that cause unnecessary downtimeThis resolves a 6-year-old issue that has affected many PM2 users who need to update application configurations without downtime.