Skip to content

Minor CPU performance improvement #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor CPU performance improvement #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Editor/SDFTextureEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ static void DoHandles(Bounds bounds)

foreach(var offset in offsets)
{
Vector3 handlePos = dir * (s_Slice - 0.5f) * bounds.size[axis] + offset;
Vector3 handlePos = (s_Slice - 0.5f) * bounds.size[axis] * dir + offset;
float handleSize = new Vector2(bounds.size[(axis + 1)%3], bounds.size[(axis + 2)%3]).magnitude * 0.03f;
handlePos = Handles.Slider(handlePos, dir, handleSize, Handles.CubeHandleCap, snap:-1);
s_Slice = Mathf.Clamp01(handlePos[axis]/bounds.size[axis] + 0.5f);
Expand Down Expand Up @@ -142,7 +142,7 @@ public override void OnInspectorGUI()
case SDFTexture.Mode.Dynamic:
EditorGUILayout.PropertyField(m_Size);

Rect GetColumnRect(Rect totalRect, int column)
static Rect GetColumnRect(Rect totalRect, int column)
{
Rect rect = totalRect;
rect.xMin += (totalRect.width - 8) * (column / 3f) + column * 4;
Expand Down