feat (detectors): include full frozen stream stats in FrozenVideoTrackDetector result #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatson
force-pushed
the
feat/frozen-video-stats
branch
from
2b284d6 to
e888202
Compare
vatson
force-pushed
the
feat/frozen-video-stats
branch
from
e888202 to
744681b
Compare
|
Closed due to inability to pass linter check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FrozenVideoTrackDetectorpreviously reported only SSRCs of frozen streams in thestatsSample.This PR extends the output to include the full frozen stream objects, which contain additional properties such as:
avgFreezeDurationMsfrozenDurationPctWhy
These extra fields are very useful for debugging and monitoring, since they expose the actual measured freeze durations instead of just identifiers.
The change is backwards-compatible because the
ssrcsarray is still included.Possible follow-up
If the team prefers more control, I could make this behavior optional by introducing a
verbose(or similar) flag in the detector’s constructor. This would allow toggling between minimal and detailed output without changing existing integrations.