fixes #8576 Cursor position is broken at v1.26.0 #8610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the cursor moves in insert, there is no need to execute selection logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cursor moves in insert, there is no need to execute selection logic
What this PR does / why we need it:
This PR Fix #7159 bad handling of auto-surrounding selections by Elliot-Roberts · Pull Request #8533 · VSCodeVim/Vim introduces another new bug when solving a bug
For specific bug, please refer to Cursor position with
Foldfixenabled is broken as ofv1.26.0update · Issue #8576 · VSCodeVim/VimI located it here through debugging and also compared it with the previous version (without this bug)
Discovered that it was this code that caused it
Which issue(s) this PR fixes
Cursor position with
Foldfixenabled is broken as ofv1.26.0update · Issue #8576 · VSCodeVim/VimSpecial notes for your reviewer: