multiple self managed hosts

[dyitzchaki-roku]

In my work we have more than one self managed gitlab hosts used in a single project.
Can you please support passing a list of hosts?

[ValentinFrancois]

Hi! This should be already supported, although not properly documented and type-hinted.

See https://github.com/ValentinFrancois/python-gitlab-submodule/blob/main/gitlab_submodule/submodule_to_project.py#L65

[dyitzchaki-roku]

Thank you, I can confirm it works.
Feel free to close the issue or leave it until this is documented.

[dyitzchaki-roku]

Oops, spoke too soon there. It actually only fetches submodules from the same host as the super project.
I think this requires passing different Gitlab instances, one for every host.

[ValentinFrancois]

@dyitzchaki-roku Ah I think I get it now.

So if I understood correctly, now everything works as expected until this line which complains that the repo of the submodule was not found on the self-managed Gitlab host:

python-gitlab-submodule/gitlab_submodule/submodule_to_project.py

Lines 28 to 29 in 0ed164d

	submodule_project = project_manager.get(
	submodule_project_path_with_namespace)

And this is because you're passing a Gitlab client for self-managed host A but some of the submodules live in self-managed host B.
Correct?

And your solution would be to pass a list of Gitlab or ProjectManager objects as the gl argument of list_subprojects ;
then, inside submodule_to_project, I would need to pick the correct Gitlab/ProjectManager object from that list (depending on the URL of the submodule).

If this sounds good then I can work on a fix soon-ish.

[dyitzchaki-roku]

Your description is correct and the solution is what I had in mind.
You can then probably use that same argument as the source for self_managed_gitlab_host too.

[ValentinFrancois]

@dyitzchaki-roku Hi,

would you mind checking out branch minor/support-multiple-self-hosted-urls and trying out passing a list of Gitlab clients for each of your self-managed hosts to list_subprojects?

I currently don't have such a setup where I could test the changes.

(param self_managed_gitlab_host is obsolete now btw)

[dyitzchaki-roku]

Thanks @ValentinFrancois, this looks fine from my end.

[ValentinFrancois]

Great thanks, let's merge then