LOG-4366: fix ruby net/http.rb to honor no_proxy in start method #101
Conversation
|
@jcantrill: This pull request references LOG-4366 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jcantrill: This pull request references LOG-4366 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jcantrill
force-pushed
the
log4366_57
branch
from
80ff3f2 to
d21012a
Compare
| COPY ${upstream_code}/install-gems.sh ${HOME}/vendored_gem_src/ | ||
| COPY ${upstream_code}/*.patch.sh ${HOME}/vendored_gem_src/ | ||
| COPY ${upstream_code}/*.patch ${HOME}/vendored_gem_src/ | ||
| RUN rm ${HOME}/vendored_gem_src/log4366_ruby_lib_net_http.patch |
There was a problem hiding this comment.
nit: will be useful for future to add some comment here because not clear why we copy patches and on next step remove this particular file
|
/lgtm |
4 participants
Description
This PR:
Links