settings page dependency chooser

[jchris]

how about exposing this on the ui? then it is more deterministic

Originally posted by @necrodome in #202 (comment)

[jchris]

this would be on the settings page @CharlieHelps make a pr

[charliecreates]

Expand this to see my work.

• Mapped dependency settings from llmsCatalog and confirmed integration points in app/routes/settings.tsx for deterministic selection and persistence.
• Refactored settings hook usage and form to allow editing and saving dependencies (string[]), with validation and DEFAULT_DEPENDENCIES fallback, using only allowed options.
• Added and styled a multi-select UI to the Settings form with loading, error, and save states, and integrated dependency control as a settings group matching app conventions.
• Integrated validated dependency saving and error/success feedback into handleSubmit in settings.tsx.
• Patched makeBaseSystemPrompt and removed legacy, AI-based/residual automatic selection functions in app/prompts.ts in favor of using the persisted settings value.
• Added unit/integration tests (tests/prompts-dependencies.integration.test.ts) verifying explicit and defaulted dependency application in makeBaseSystemPrompt.
• Cleaned up unused types/variables and legacy logic in prompts.ts, iteratively running and re-running pnpm typecheck to address new or remaining TS errors.
• Ran pnpm typecheck successfully with no errors after final cleanup.
• Updated tests/prompt-builder.test.ts to dynamically use the explicit dependencies (from DEFAULT_DEPENDENCIES) in all assertions regarding imports and LLM docs, matching new deterministic, user-facing selection behavior.
• Opened PR #223 with a detailed description and verification, and requested review from jchris and necrodome.

[charliecreates]

Opened PR: feat(settings): add dependency chooser for deterministic library selection

Short version: I added a Libraries (dependency) chooser to the Settings page and wired it end‑to‑end so the selected libraries are used deterministically across the app.

What changed

• Settings UI
  • New “Libraries” section on /settings with checkboxes populated from the same catalog we use for prompts (app/llms/*.json).
  • Shows current selection on load. If nothing is saved yet, defaults to fireproof + callai and shows them checked.
  • Save validates against the catalog and persists to the settings document, with success/error states.
• Settings storage
  • Extended UserSettings with dependencies: string[].
  • Shared catalog in app/llms/catalog.ts exporting llmsCatalog and DEFAULT_DEPENDENCIES.
• Prompt composition
  • makeBaseSystemPrompt() now honors settings.dependencies (or falls back to DEFAULT_DEPENDENCIES). The import block and concatenated docs are generated only for the selected libraries, making prompt composition deterministic.
• Tests
  • Updated prompt builder expectations for deterministic selection.
  • Added integration tests asserting default and explicit dependency behavior.
  • Added UI tests for the new Settings “Libraries” section and persistence.

Default and scope

• Default (if no saved value): ['fireproof', 'callai'].
• Scope: project/application (stored in the main settings document _id: user_settings in the SETTINGS_DBNAME DB).
• Changes take effect immediately; no rebuild/restart needed.
• Permissions model unchanged; the same settings write path is used.

Links

• PR: feat(settings): add dependency chooser for deterministic library selection #223
• Closes settings page dependency chooser #215

Files touched

• app/llms/catalog.ts (new): shared catalog + DEFAULT_DEPENDENCIES
• app/types/settings.ts: add dependencies: string[]
• app/routes/settings.tsx: add Libraries chooser, validation, save feedback
• app/prompts.ts: honor Settings.dependencies (or default) for imports + docs
• tests/prompt-builder.test.ts: update for deterministic selection
• tests/prompts-dependencies.integration.test.ts: new integration tests
• tests/settings-dependencies.test.tsx: new UI tests

UX notes

- Loading: options are static (from local JSON); UI renders immediately. - Disabled state: if catalog is ever empty, the section shows “No libraries available.” - Errors: save failure surfaces a small inline error; success shows a lightweight confirmation. - Validation: only catalog names are saved; invalid/deprecated names are filtered out on save.

Verification

Commands and results:

• pnpm format: ok
• pnpm typecheck: ok
• pnpm test: 67 files, 366 passed, 4 skipped

[jchris]

@CharlieHelps apologies I was not specific enough that PR was for the wrong page in the app. I meant this should be per-vibe and on the App Settings page which was introduced in c046dac

[charliecreates]

Expand this to see my work.

• Traced the full dependency selection path in app/prompts.ts and verified that the Vibe's dependencies, via sessionDoc.dependencies, determine the list used for prompt generation, falling back to DEFAULT_DEPENDENCIES if unset.
• Audited and removed global chooser logic from app/routes/settings.tsx and app/types/settings.ts as well as any lingering global settings references.
• Added a dependencies?: string[] field to VibeDocument in app/types/chat.ts for per-vibe persistence.
• Migrated the Libraries chooser UI to AppSettingsView in app/components/ResultPreview/AppSettingsView.tsx, including validation and save via the per-vibe onUpdateDependencies.
• Wired up prop threading for per-vibe dependencies in ResultPreview.tsx and patched useSystemPromptManager to always source dependencies from the active Vibe.
• Deleted dead tests for the global settings UI and introduced new UI and integration tests at tests/appSettings-dependencies.test.tsx and updated tests/prompts-dependencies.integration.test.ts for the per-vibe context.
• Ran full formatting, typecheck, and test suite—confirmed all lint, type, and test results are clean except unrelated minor test warnings (see output).
• Committed changes in 46d1892: removed all global persistence/UI, relocated chooser to per-vibe App Settings, updated types, and revised all related tests.

[charliecreates]

Thanks for the clarification—done. I moved the Libraries chooser to the per‑vibe App Settings and scoped everything per Vibe.

• UI: Added a “Libraries” section to the App Settings view (the Settings tab inside the preview). It’s a checkbox list from the shared catalog, defaults to the same core libs, and saves with validation to the current vibe.
• Persistence: Stored as dependencies: string[] on the session’s vibe document (per‑vibe).
• Prompts: Prompt composition now reads the active vibe’s dependencies (with DEFAULT_DEPENDENCIES fallback) via useSystemPromptManager → makeBaseSystemPrompt.
• Global cleanup: Removed the Libraries chooser from /settings and dropped dependencies from UserSettings.
• Tests: Replaced the global settings UI test with a per‑vibe App Settings UI test; prompt integration tests remain valid.

PR: #229

Impacted files (high‑level)

• app/components/ResultPreview/AppSettingsView.tsx (new Libraries section)
• app/components/ResultPreview/ResultPreview.tsx (passes vibe deps + updater)
• app/hooks/useSession.ts (exposes updateDependencies; validates against catalog)
• app/hooks/useSystemPromptManager.ts (merges vibe doc into prompt context)
• app/routes/settings.tsx (removed global Libraries UI and logic)
• app/types/chat.ts (VibeDocument.dependencies?: string[])
• app/types/settings.ts (removed dependencies)
• tests/appSettings-dependencies.test.tsx (new UI test)
• tests/settings-dependencies.test.tsx (removed; feature moved)

Verification

• pnpm format: ok
• pnpm typecheck: ok
• pnpm test: 67 files, 366 passed, 4 skipped

Notes

• I did not migrate the short‑lived global dependencies value; say the word if you want me to copy that selection into all existing vibes as an initialization step.