Skip to content

fix: try removing release flag #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: try removing release flag #3119

merged 1 commit into from
Aug 21, 2024

Conversation

@kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Aug 20, 2024 •
edited
Loading

resolves: #3115

@kasiaMarek kasiaMarek marked this pull request as ready for review August 21, 2024 11:20
@kasiaMarek kasiaMarek requested a review from Gedochao August 21, 2024 11:20
Gedochao
Gedochao approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder at what point did we stop needing it. 🤔
Either way, LGTM

@Gedochao Gedochao merged commit 58f5a76 into VirtusLab:main Aug 21, 2024
@kasiaMarek
Copy link
Contributor Author

kasiaMarek commented Aug 21, 2024 •
edited
Loading

I wonder at what point did we stop needing it.

Possibly here: #2985. I just deleted it only for bloop not knowing that originally it was added for bloop (I think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

scala-cli eagerly sets -release / -java-output-version, which prevents compiling on new Java versions

2 participants

@kasiaMarek @Gedochao