Skip to content

Conversation

@Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Oct 28, 2025

What was done

Potential follow-ups

  • completely remove expecty from the project
    • way out of scope for this PR
    • this was tempting to do here, but requires a project-wide refactor
    • tl;dr we now have the workarounds around the issues mentioned above everywhere, and the library is perhaps more trouble than it is worth
  • cross-compile the integration module against Scala 3 Next versions
    • this would be a good idea both for dogfooding and in preparation to the 3.9 LTS bump
    • it may be a good idea to finally bump to Mill 1.x, first

@Gedochao Gedochao force-pushed the maintenance/integration-scala3 branch 4 times, most recently from 747cc58 to 781192e Compare October 28, 2025 13:01
@Gedochao Gedochao changed the title [WIP] Migrate integration tests to Scala 3 Migrate integration tests to Scala 3 Oct 28, 2025
@Gedochao Gedochao marked this pull request as ready for review October 28, 2025 15:36
@Gedochao Gedochao requested review from tgodzik and zielinsky October 28, 2025 15:36
Copy link

@zielinsky zielinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor change from me

@Gedochao Gedochao requested a review from zielinsky October 29, 2025 06:45
@Gedochao Gedochao force-pushed the maintenance/integration-scala3 branch from 070f993 to fa13b72 Compare October 29, 2025 06:52
@Gedochao Gedochao force-pushed the maintenance/integration-scala3 branch from fa13b72 to e9fa40f Compare October 29, 2025 06:53
@Gedochao Gedochao merged commit 863bec3 into VirtusLab:main Oct 29, 2025
103 of 106 checks passed
@Gedochao Gedochao deleted the maintenance/integration-scala3 branch October 29, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants