Crash when using prebuilt v8.5.2 with Electron 26.1.0

[linonetwo]

Error message before crash is

[20860:0821/201632.615257:ERROR:child_thread_impl.cc(235)] Invalid PlatformChannel receive right

Code is

      let database: Sqlite3Database.Database;
      try {
        database = new Sqlite3Database(':memory:', { verbose: logger.debug, nativeBinding: SQLITE_BINARY_PATH });
      } catch (error) {
        logger.error(`error when loading sqlite3 for workspace ${workspaceID}, skip because of error to prevent crash: ${(error as Error).message}`);
        return;
      }

It was working in 8.4.0 + "electron": "25.2.0",

Not working with 8.5.1 + "electron": "26.0.0", or 8.4.0 + + "electron": "26.0.0",

So it is electron's falut.

[linonetwo]

electron/electron#39600

Using electron fiddle, I found

  const Sqlite3Database = require('better-sqlite3')
  const db = new Sqlite3Database(':memory:', { verbose: console.log, nativeBinding: '/Users/linonetwo/Desktop/repo/TiddlyGit-Desktop/node_modules/better-sqlite3/build/Release/better_sqlite3.node' });

won't crash. But closing the db will:

  //  ↓THIS Line cause problem! ↓
  db.close();

But I'm curious, why db.close() will cause the crash?

---

It's different, in my app, let database = new Sqlite3Database(':memory:', { nativeBinding: SQLITE_BINARY_PATH }); does the crash, but in electron fiddle, db.close() does it...

[mceachen]

Thanks for reporting, @linonetwo . @neoxpert contributed more context in #1053.

[mceachen]

Using @neoxpert 's repo, manually rebuilding fixes the issue:

npm install
cd node_modules/better-sqlite3
npx node-gyp rebuild --debug --build-from-source --runtime=electron --target=26.1.0 --dist-url=https://electronjs.org/headers
cd ../..
npm run start

Including --debug, omitting --debug, or replacing --debug with --release all result in a non-crashing better_sqlite3.node.

So it looks like the pre-built binary doesn't work correctly.

[linonetwo]

But wasn't the prebuilt binary generated in Github action in the same cli command? Can you rerun action to publish a new one?

So is this a bug on Electron or here, do I need to close the issue there?

[mceachen]

I've kicked off a rebuild for the latest version, but I suspect the same binaries will be emitted. I'll look into it a bit more tomorrow. @JoshuaWise if you've got any suggestions, that'd be great.

[mceachen]

Harumph--rebuilding resulted in the same behavior. Until this is properly resolved, I'd run #1044 (comment) in your postinstall.