Add healthcheck commands for MySQL containers #70987
Closed
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.91 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
added
the
[Type] Automated Testing
SirLouen
reviewed
Jul 30, 2025
There was a problem hiding this comment.
Just writing this review as a reminder to add the conditional for the healtcheck.sh
t-hamano
reviewed
Jul 31, 2025
| const healthcheck = { | ||
| test: [ | ||
| 'CMD-SHELL', | ||
| 'if [ "$LOCAL_DB_TYPE" = "mariadb" ]; then case "$LOCAL_DB_VERSION" in 5.5|10.0|10.1|10.2|10.3) mysqladmin ping -h localhost || exit $?;; *) mariadb-admin ping -h localhost || exit $?;; esac; fi', |
There was a problem hiding this comment.
I'm not very familiar with Docker, but I think LOCAL_DB_TYPE and LOCAL_DB_VERSION are environment variables for core development. I think the image is always mariadb in wp-env, so can we simplify the command a bit?
There was a problem hiding this comment.
Ah yes, you're right. Looks like lts is always used as the version as well. So there's no need to guard against differences in older versions.
Comment on lines
-195
to
+205
| volumes: [ 'mysql:/var/lib/mysql' ], | ||
| healthcheck, |
There was a problem hiding this comment.
I don't think we can delete the volumes field because the database is reset every time we restart the environment.
|
I was mistaken that the version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds some additional safe guards so that running
wp-env startdoes not fail when a database container takes a while to finish starting.depends_onsetting for containers that rely on a database container has been expanded to expect aservice_healthystatus.healthcheckthat waits for a successful response to(mysql|mariadb)-admin pingcommand and retries up to 10 times.Why?
The
wp-env startcommand has been failing more frequently within GitHub Actions recently.How?
Testing Instructions