Skip to content

Fix Core Widget Fields Not Rendering "0" Value #7785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

Sukhendu2002
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/38133

Description

This PR fixes an issue where core widget fields fail to render when the value is "0". The problem occurs because empty() checks in widget fields treat "0" as an empty value, causing widgets to not display content when "0" is the only value.

Problem

Currently, if you set a single "0" as the value in many default widgets (e.g., widget title or content), it won't output anything due to the use of empty() checks. The issue arises because empty() returns TRUE for "0" values, treating them as empty.

For example:

  • Setting a widget title to "0" results in no title being displayed
  • Multiple zeros ("00") or other values work correctly
  • This affects multiple default widgets where empty() is used for validation

Solution

Replace empty() checks with explicit isset() and string comparison:

// Before
if ( ! empty( $instance['title'] ) ) {
    $title = $instance['title'];
}

// After
if ( isset( $instance['title'] ) && '' !== $instance['title'] ) {
    $title = $instance['title'];
}

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sukhendu2002.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant