[TOSA] Fix result type for Conv1D operations. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttjost
force-pushed
the
tiagot.fix_result_type_conv1d
branch
2 times, most recently
from
2182968 to
9e8c284
Compare
Collaborator
|
Why did this not come up in the end2end tests? Should we have an end2end test covering this? |
mgehre-amd
approved these changes
Jun 9, 2023
Collaborator
mgehre-amd
left a comment
mgehre-amd
left a comment
There was a problem hiding this comment.
LGTM, but check end2end test
Author
So, we didn't see it before because we were only doing non-group Conv1D, and the type was not properly set for Group convolution. I will wait for #78 to get merged and then update this PR with a test for it. |
ttjost
force-pushed
the
tiagot.fix_result_type_conv1d
branch
from
9e8c284 to
baf0da4
Compare
ttjost
changed the base branch from
feature/misc_fixes
to
tiagot.tosa_group_convolution
ttjost
force-pushed
the
tiagot.fix_result_type_conv1d
branch
from
baf0da4 to
7d0bfc0
Compare
…o tiagot.tosa_group_convolution
ttjost
changed the base branch from
tiagot.tosa_group_convolution
to
feature/misc_fixes
ttjost
changed the base branch from
feature/misc_fixes
to
tiagot.tosa_group_convolution
…ch-mlir into tiagot.fix_result_type_conv1d
ttjost
force-pushed
the
tiagot.fix_result_type_conv1d
branch
from
9177df8 to
0af2ef3
Compare
Author
|
I added a test that covers this issue. |
Base automatically changed from
tiagot.tosa_group_convolution
to
feature/misc_fixes
June 9, 2023 14:44
…o tiagot.fix_result_type_conv1d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conv1D simplication had a wrong output type. This PR fixes the issue.