Skip to content

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jun 12, 2025

Proposed changes

Notice: This PR breaks the testcases TestRevertStates and TestDumpState. I didn't fix them since XDCx and XDCxlending have been abandoned.

Ref: ethereum#25320

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan force-pushed the rework-trie-committer branch 2 times, most recently from 9a635ee to e45ede3 Compare June 13, 2025 03:01
@gzliudan gzliudan force-pushed the rework-trie-committer branch from e45ede3 to 91e8cb0 Compare June 23, 2025 12:01
* all: rework trie and trie committer

* all: get rid of internal cache in trie

* all: fixes

* trie: polish

* core, trie: address comments

* trie: fix imports

* core/state: address comments

* core/state/snapshot: polish

* trie: remove unused code

* trie: update tests

* trie: don't set db as nil

* trie: address comments

* trie: unskip test
@gzliudan gzliudan changed the title [WIP] all: rework trie committer #25320 all: rework trie committer #25320 Aug 28, 2025
@gzliudan gzliudan force-pushed the rework-trie-committer branch from 91e8cb0 to ecf1a42 Compare August 28, 2025 22:11
@gzliudan gzliudan merged commit 6c5c8c1 into XinFinOrg:dev-upgrade Aug 31, 2025
12 checks passed
@gzliudan gzliudan deleted the rework-trie-committer branch August 31, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants