-
Notifications
You must be signed in to change notification settings - Fork 142
Add .Net Core support #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestDiscGolf
approved these changes
Aug 1, 2017
Contributor
WestDiscGolf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome :)
Contributor
Author
|
Thanks! :) |
|
Very cool. Looking forward to testing it out. |
Contributor
|
Going to give this a test through! Awesome! |
99b1693 to
7233a5d
Compare
Updated all the tests that check exception to the new model for validating exceptions.
Before, the tests were assuming that the sample data was in a relative path to where the tests were running. With the change, the value of the SampleData folder is calculated based on the location of the test assembly. As part of this change, I also ensured that the sample data is copied over to the test location.
7233a5d to
593a705
Compare
6ee7dc2 to
3ef327c
Compare
Contributor
|
Thanks for your work on this @AlexGhiondea ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for building the library to target .NET Standard 1.3.
In order to maintain compat with older version of .NET Framework, the library is cross-compiled to .NET Framework 4.5 as well.
Changes included:
NETSTANDARD1_3This v3.0 branch should merge this PR once it is approved: #223