Skip to content

Conversation

@WestDiscGolf
Copy link
Contributor

The general theme for this pull request is update and clean to aid with on boarding when new people start using the library and ready for the next release. The repository was generally a bit of a mess if we're being honest and this prevents people from understanding, consuming and contributing.

I also took the opportunity to remove the multiple solutions we had in the repository and clean that up as well. With the progression which has occurred with netstandard in the past year I have updated the project to multi target netstandard1.3 (is this still required?!) and netstandard2.0 and made the unit tests run on .NETCoreApp 2.1, 2.2 and .NETFramwork 4.6.1

In more detail:

  1. Removed the old OAuth 1 related projects as no longer required.
  2. Removed the "live debug" example, as no longer required and over complicated.
  3. Removed the old MVC sample and re-added with a more simpler cut down version
  4. (re)Added in Alex's sample console application (+ couple of tweaks)
  5. Upgraded Fitbit.Portable and Tests to use the new csproj version to allow for multi target
  6. Remove un-required packages related items, eg. .nuget folder and packages.config
  7. Upgraded some of the supporting nuget packages

And it addresses: #231, #230, #182, #237

@aarondcoleman There are a number of items from your team which I wasn't sure which branch they were/weren't in so there maybe commits in the request which have already been merged into the right place.

@AlexGhiondea Would be good to get your feedback on this request from a netstandard/netcore perspective now I've managed to merge all the projects into one with multi targeting.

redmorello and others added 30 commits March 10, 2017 12:35
Updated all the tests that check exception to the new model for validating
exceptions.
Before, the tests were assuming that the sample data was in a relative path to where the tests were running.
With the change, the value of the SampleData folder is calculated based on the location of the test assembly.

As part of this change, I also ensured that the sample data is copied over to the test location.
…t-rate-methods-to-interface

add heart rate methods to IFitBitClient interface
dwaynefitabase and others added 27 commits September 29, 2017 20:46
…ayActivityLogs

Issue232 one day activity logs
…es()

This prevents errors in HttpClient if the URL is malformed by omission of userId resulting in user//activities. In this case, the current version of HttpClient exhibits the behvior of switching from https to http (causing a fitbit error)
…Extensions.ToFullUrl(). Add better documentation on ToFullUrl()
…eartRateTimeSeriesNullGuard

add IsNullOrWhiteSpace guard for userId param of GetHeartRateTimeSeri…
…HttpStatusCodeToInt

Issue243 cast http status code to int
…rate slns. Add multi target testing in the tests project; .NETCoreApp 2.1, 2.2 and .NETFramework 4.6.1
Renamed it to make it clearer and removed unrequired code to aid with getting started.
@aarondcoleman
Copy link
Owner

aarondcoleman commented Jan 6, 2019 via email

@AlexGhiondea
Copy link
Contributor

Hey — didn’t see the notification for this until now — will take a look over the weekend!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants