-
Notifications
You must be signed in to change notification settings - Fork 438
chore: screening optimisations #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
Page | Size (compressed) |
---|---|
global |
471.43 KB (🟡 +46 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
|
|
|
all good, case
result:
I think we don't need to make a second request |
Unfortunately, this isn't something that can be changed on the interface side. The |
|
* chore: export state to exclude mock wallet from screening * chore: disable screening if watch mode enabled * fix: stub address screening api call * fix: tests wallet connect * fix: revet intercept Co-authored-by: Mark Grothe <[email protected]> Co-authored-by: NikitaY <[email protected]>
General Changes
To test: check different combinations of connecting, disconnecting, and switching between normal and mocked wallet and check that no request is made to
https://aave-api-v2.aave.com/addresses/status?address
for mocked walletDeveloper Notes
Does not use existing
watchModeOnlyAddress
parameter which is exported from Web3Provider becausecurrentAccount
andwatchModeOnlyAddress
are updated asyncronouslyAuthor Checklist
Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.
main
If the PR is ready for review:
Open
state and not inDraft
modeReady for Dev Review
label has been addedReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.example
file as well as the pertinant.github/actions/*
files