Skip to content

Conversation

@JonoYang
Copy link
Member

@JonoYang JonoYang commented Dec 1, 2022

Signed-off-by: Jono Yang [email protected]

@JonoYang JonoYang requested a review from pombredanne December 1, 2022 00:16
Signed-off-by: Jono Yang <[email protected]>
@JonoYang JonoYang force-pushed the 48-correctly-assign-codebase-attributes branch 2 times, most recently from 94707c6 to b9bdf5f Compare February 4, 2023 01:35
@JonoYang JonoYang force-pushed the 48-correctly-assign-codebase-attributes branch from b9bdf5f to 59c9c17 Compare February 4, 2023 01:36
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with only one small nit to fix.
Thanks!

@JonoYang JonoYang merged commit a31199f into main Feb 23, 2023
@pombredanne pombredanne deleted the 48-correctly-assign-codebase-attributes branch February 24, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants