Remove unused test files #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused test files with a convoluted history.
The file "tests/data/fileutils/textfiles/mac_newlines.txt" used to be a test file for a now deleted "read_text_file" function and was picked as it had peculiar old style line endings seen only on macOS classic files with only a bare "\R".
Here is the backgrounder:
This is code with a complex history as it was also published under a proprietary license at:
https://web.archive.org/web/20000823095253/http://java.sun.com/products/jfc/tsc/articles/treetable2/src/MergeSort.java
and at:
https://web.archive.org/web/20000823094850/http://java.sun.com/products/jfc/tsc/articles/treetable1/src/MergeSort.java
and is part of code that was relicensed by Sun following some issues raised many years ago.
The earliest relicense is at
https://web.archive.org/web/20030709130712/http://java.sun.com:80/products/jfc/tsc/articles/treetable1/src/MergeSort.java
The detailed history is found foremost in this Mozilla bugzilla:
https://bugzilla.mozilla.org/show_bug.cgi?id=419491and
And also in Mozilla Rhino history at:
https://github.com/mozilla/rhino/blob/2c8ae233cda5d6129a140e5572a6dda148afc039/toolsrc/org/mozilla/javascript/tools/debugger/build.xml#L40
and:
mozilla/rhino@2e746cd
The gist of this is that all versions prior to Mozilla Rhino prior to
1.7R1 contained Sun proprietary binary code injected at build time that
was fetched from code listed above and attached to the article at:
https://web.archive.org/web/20020520083650/http://java.sun.com/products/jfc/tsc/articles/treetable2/
This meant that use of those versions would have required permission
from Sun (now Oracle) to use and distribute these Sun proprietary
components. Sun subsequently released and updated the code under a
BSD style license, and Rhino 1.7R1 and later further vendored the code
now at:
https://github.com/mozilla/rhino/tree/6387bac4281ba1c4a8050cd055071615593d214c/toolsrc/org/mozilla/javascript/tools/debugger/treetable
Ironically I am tied to the history of this relicensing somehow as seen
in comments in at
https://bugzilla.mozilla.org/show_bug.cgi?id=419491
This was also an issue for larger users of Rhino as per https://bugzilla.redhat.com/show_bug.cgi?format=multiple&id=457336 which also claims that Sun relicensed this for use in OpenOffice.
More details for the posterity: Circa 1998, Sun employees published an
article with some source code attached. The code was under a Sun
proprietary license. Circa 2008, at the request of the Mozilla Rhino
project (which was using that code) Sun relicensed part of that article
attached code under a new BSD license (as explained in
https://bugzilla.mozilla.org/show_bug.cgi?id=419491 ).
This code was also already relicensed under an earlier version of the
article in 2003 under a BSD-style license.
This test file (used for testing line endings on old MacOS) was using
originally the proprietary-licensed variant.
This is NOT part of the released commoncode wheels deployed at runtime
and is not an issue per-se since this code was also licensed by SUN
under this BSD-style license
https://scancode-licensedb.aboutcode.org/sun-bsd-no-nuclear.html
This file is therefore updated here to use the
sun-bsd-no-nuclear-licensed version and will be deleted afterwards as
this is no longer used in commoncode as the read_text_file() function
it tested as been removed.