Skip to content

Conversation

TG1999
Copy link
Collaborator

@TG1999 TG1999 commented Aug 6, 2025

fixes: aboutcode-org/scancode.io#1383

The API design would look something like this

>>> from fetchcode import fetch
>>> resp = fetch("pkg:pypi/[email protected]")

Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Copy link

@tdruez tdruez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. Also there's a lack of unit test for this code.

TG1999 added 2 commits August 6, 2025 14:08
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Copy link

@tdruez tdruez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage is too light, it does not cover properly the new code.
Also, the mocking is not ideal.

Lastly, that new PURL support should be documented, and probably displayed in the README

TG1999 added 2 commits August 7, 2025 14:41
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Copy link

@tdruez tdruez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for merge.

@TG1999 TG1999 merged commit 92dedc8 into master Aug 7, 2025
9 checks passed
@TG1999 TG1999 deleted the add_support_to_fetch_purl branch August 7, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use PURL for inputs

2 participants