Add docs, changelog and authors in CONTRIBUTION and fix typos and errors #3204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do I fix these errors? |
|
You don't need to worry about the failing test at |
|
@AyanSinhaMahapatra Sir, gentle ping. Do you happen to have any updates on this one? |
AyanSinhaMahapatra
requested changes
Jan 31, 2023
|
@OctoPie23 can you rebase this into one commit and add a signoff so the DCO is passing properly? |
|
Sir, I have been away from home for three days. It was necessary. My laptop
isn't with me right now. I'll do it as soon as I get back.
Hope you understand :)
…On Sat, Feb 18, 2023, 12:01 AM Ayan Sinha Mahapatra < ***@***.***> wrote:
@OctoPie23 <https://github.com/OctoPie23> can you rebase this into one
commit and add a signoff so the DCO is passing properly?
—
Reply to this email directly, view it on GitHub
<#3204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASKYBYUH2ZWV3J6SJ7MVDQDWX66AFANCNFSM6AAAAAAT6FLFG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
add docs, changelog and authors in Development. fixes #2252 Signed-off-by: Shrijal Acharya <[email protected]> Signed-off-by: OctoPie23 <[email protected]>
Signed-off-by: OctoPie23 <[email protected]>
@AyanSinhaMahapatra Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs, changelog, and authors in Development. Also fixed some minor typos and errors.
Hopefully, this fixes #2252
Tasks
Run tests locally to check for errors.
Signed-off-by: Shrijal Acharya [email protected]