Skip to content

Add nuget nuspec dependencies #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 18, 2023
Merged

Add nuget nuspec dependencies #3206

merged 8 commits into from
Jan 18, 2023

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Jan 18, 2023 •
edited
Loading

This PR adds support for nuspec dependencies and builds on top of #3121

Reference: #2308
Reference: #648

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

bloodhoundGit and others added 8 commits November 18, 2022 15:46
@bloodhoundGit
fix(nuget): add nuget dependency extract
a05670b 
Signed-off-by: Abedin Poonawala <[email protected]>
@bloodhoundGit
feat(nuget): add dependency check for inside group tags
a228078 
    1. update code to look for dependencies in a group as well
    2. update nuget test data with dependency data

Signed-off-by: Abedin Poonawala <[email protected]>
@bloodhoundGit
fix(nuget): match updated develop code
f370581 
Signed-off-by: Abedin Poonawala <[email protected]>
@bloodhoundGit
fix(nuget): update nuget test
fc2d36a 
Signed-off-by: Abedin Poonawala <[email protected]>
@bloodhoundGit
fix(nuget): add dependency section in bootstrap test
60a14ec 
Signed-off-by: Abedin Poonawala <[email protected]>
@pombredanne
Refine NuGet nuspec dependency extraction
a6017f5 
Factor out common code in function, also include framework
and set dependency flags accordingly.

Reference: #2308
Reference: #648
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne
Merge latest develop
414629f 
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne
Regenerate NuGet tests after develop merge
b62eb68 
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne pombredanne mentioned this pull request Jan 18, 2023
Closed
4 tasks
@pombredanne
Copy link
Member Author

All green... merging

@pombredanne pombredanne merged commit 1697461 into develop Jan 18, 2023
@pombredanne pombredanne deleted the add-nuget-dependencies branch January 18, 2023 09:08
@pombredanne pombredanne added this to the v32.0 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v32.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pombredanne @bloodhoundGit