Skip to content

Silence pyicu warning #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2023
Merged

Silence pyicu warning #3280

merged 2 commits into from
Apr 3, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Feb 28, 2023 •
edited
Loading

Fixes #2990

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Feb 28, 2023
Closed
4 tasks
@AyanSinhaMahapatra
Remove noisy ICUWARNING #2990
456665b 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
JonoYang
JonoYang approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AyanSinhaMahapatra
Copy link
Member Author

Thanks @JonoYang @pombredanne , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 50206ef into develop Apr 3, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the silence-pyicu-warning branch April 3, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

@JonoYang JonoYang JonoYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silence noisy warnings for pyicu
4 participants
@AyanSinhaMahapatra @pombredanne @JonoYang @rritik772