Skip to content

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Apr 24, 2023

Refernce: #3343

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!
Please merge once you have added a changelog entry

@AyanSinhaMahapatra
Copy link
Member Author

AyanSinhaMahapatra commented Apr 24, 2023

The bug was reproduced at https://dev.azure.com/nexB/scancode-toolkit/_build/results?buildId=10600&view=logs&j=e968ac97-6fe5-5e03-7848-d38fdbd63e89&t=68b960ee-accc-5f66-8291-47be569f7afb&l=8852, turns out it was a general issue and not dependent on input. This happened only when not using the --license-text option with --unknown-licenses, but now it's been fixed. We also added more tests for this option too.

@armijnhemel could you rescan from this branch and check if this fixes your issue too? Thanks!

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

All green! merging this!
@armijnhemel I'm Keeping the issue #3343 open till you report back whether the fix is working for you so let us know there, thanks++ for the report!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 132884d into develop Apr 24, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the fix-unknown-license-detection branch April 24, 2023 18:22
@AyanSinhaMahapatra AyanSinhaMahapatra restored the fix-unknown-license-detection branch April 26, 2023 22:39
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the fix-unknown-license-detection branch April 26, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants