3396 update get license detections and expression #3397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set default default_relation_license if the PackageData has no datasource_id
* Create a test to ensure that we can create a Package whose type we do not have a DatafileHandler for
Signed-off-by: Jono Yang <[email protected]>
* 5.3.0 is the last version that can use docutils < 0.17 Signed-off-by: Jono Yang <[email protected]>
JonoYang
force-pushed
the
3396-update-get-license-detections-and-expression
branch
from
afb6c58 to
e833792
Compare
AyanSinhaMahapatra
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the fix by @AyanSinhaMahapatra in
PackageData.get_license_detections_and_expression()where a default value fordefault_relation_licenseis set when aPackageDataobject does not have adatasource_idvalue.I've also pinned Sphinx to 5.3.0 to avoid the docs test failures.